Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart-sass: 1.23.7 (new formula) #47438

Closed
wants to merge 1 commit into from
Closed

Conversation

JarryShaw
Copy link
Contributor

@JarryShaw JarryShaw commented Dec 3, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Following discussion in #43388, this formula is directly copied from SASS's official Tap (sass/sass/sass).

For node implementation, please refer to #47439
For dart formula, please refer to #47442

Following discussion in Homebrew#43388
this formula is directly copied from SASS's official
Tap (`sass/sass/sass`).
@alebcay alebcay added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 3, 2019
@SMillerDev
Copy link
Member

This seems like a very odd formula, depending on a separate tap and doing weird things for 64-bit systems. What did you base this on?

@JarryShaw
Copy link
Contributor Author

JarryShaw commented Dec 4, 2019

This is the official formula of Sass (Dart implementation), copied directly from sass/sass/sass.

@SMillerDev
Copy link
Member

You might want to rework it to be in line with the homebrew-core guidelines

@JarryShaw
Copy link
Contributor Author

Will wait until dart itself is in the homebrew-core :)

@JarryShaw JarryShaw mentioned this pull request Dec 21, 2019
5 tasks
@fxcoudert
Copy link
Member

dart formula was rejected in current state, so closing this for now

@fxcoudert fxcoudert closed this Dec 24, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
@chenrui333 chenrui333 added the not merged PR was closed without being merged (and may need to be revisited) label Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core not merged PR was closed without being merged (and may need to be revisited) outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants