Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docutils 0.14_1 #35209

Closed
wants to merge 1 commit into from
Closed

docutils 0.14_1 #35209

wants to merge 1 commit into from

Conversation

JarryShaw
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • no vision update
  • revised installation script
    • changed dependency from "python" to "python@2"
    • added additional Python dependency packages ("lxml", "Pillow" and "Pygments")

- no vision update
- revised installation script
  - changed dependency from "python" to "python@2"
  - added additional Python dependency packages ("lxml", "Pillow" and "Pygments")
@lembacon
Copy link
Contributor

  • The end of life of Python 2 is within 2 years, while docutils does support Python 3, I do not see any obvious reasons to move backwards.
  • We are removing options from formulae in the core tap, if the added functionalities are valuable to everyone, we will then want to always enable them.
  • Installed dependencies must have their version pinned and have checksums of their contents verified.
  • In particular, Pillow has a lot of additional dependencies, including freetype. IMO, this would become overkill.

@JarryShaw
Copy link
Contributor Author

  • docutisl uses 2to3.py to generate Python 3 compatible distribution when installation, which some issues may exist.
  • If to build Pillow from source, yes, many dependencies are required (some are not even available from Homebrew).
  • For some reasons idk, Homebrew seems not supporting wheels from PyPI (or if I messed something up?), and that's why I made a workaround by directly install afterwards.
  • As a heavy docutils user, at least Pillow and Pygments are extremely important and it's blocking if Homebrew cannot integrate them within.

@lembacon
Copy link
Contributor

  • For some reasons idk, Homebrew seems not supporting wheels from PyPI (or if I messed something up?), and that's why I made a workaround by directly install afterwards.

No, we do not want to install from wheels. As per Acceptable Formulae, we are strongly against binary formulae, building from sources is a strict policy for the core tap.

Also from the aforementioned documentation, every dependencies must have their versions pinned and checksums verified. In this particular case, the latest versions of lxml, Pillow and Pygments will be installed, this is undesired, as this may break things from time to time. Recursive dependencies of lxml, Pillow and Pygments will also be installed in an uncontrollable manner.

@fxcoudert
Copy link
Member

For the reasons explained by @lembacon we are going to decline this.

@fxcoudert fxcoudert closed this Dec 27, 2018
@lock lock bot added the outdated PR was locked due to age label Jan 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2019
@JarryShaw JarryShaw deleted the docutils branch January 29, 2020 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants