-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protobuf: add Python 3.7 compatibility #29660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @benmwebb. This needs to be submitted upstream as a PR and then we can use a patch do
block in the formula to apply the upstream PR as a patch.
OK, I think I can do that. I was just following the example of OpenCV, which patches directly in the formula: 377ac4c. Figured that was the approved way to handle such issues. |
Upstream PR: protocolbuffers/protobuf#4862. I can update this PR once the protobuf folks merge that (or otherwise fix Python 3.7), if that works best for you guys. |
Just use |
i.e. no need to wait |
If built using --with-python, compilation fails with Python 3.7 because the Python folks changed their C API such that PyUnicode_AsUTF8AndSize() now returns a const char* rather than a char*. Add a patch to work around.
OK, PR updated to use the upstream patch. |
Thanks @benmwebb! Shipped. |
If built using --with-python, compilation fails with
Python 3.7 because the Python folks changed their C
API such that PyUnicode_AsUTF8AndSize() now returns
a const char* rather than a char*. Add a patch to
work around.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?