metricbeat 6.2.1

[tylerjl]

Created with brew bump-formula-pr.

[fxcoudert]

==> make
go build -i
go build github.com/elastic/beats/vendor/github.com/shirou/gopsutil/disk: invalid flag in #cgo LDFLAGS: -mmacosx-version-min=10.10
make: *** [metricbeat] Error 1

[tylerjl]

Thanks @fxcoudert - the root cause here is that metricbeat doesn't build on go 1.9.4. Is there a way to pin depends_on "go" => :build in the formula to 1.9.2, or alternatively, any prior art regarding respecting a file like .go-version at build time to fetch a specific version? Beats ship those files by default and would help avoid these failures in the future.

[ilovezfs]

Nope. It must build with the latest go or we'll need to remove it from Homebrew.

[tylerjl]

The aforementioned PR should get metricbeat into a state that it'll compile with the latest version of go. How do you feel about just closing this one out, and we can update metricbeat when the next release comes out with go 1.9.4 supported?

[ilovezfs]

Can that not be applied as a patch?

[tylerjl]

I'll take a look at applying it as a patch one the PR has been finalized and merged ⚡️

[ilovezfs]

@tylerjl OK thanks. We'll close this out for now then. Let me know if/when you want it re-opened.

[tylerjl]

@ilovezfs my branch now has an inline patch which works for me when building the formula from source under golang 1.9.4, there's some comments in there as well indicating when the intermediate patch can be removed once a version supporting 1.9.4 is released.

[ilovezfs]

@tylerjl cool. I've reopened this if you want to push new commits.

[tylerjl]

Looks like the latest revision with the patch builds cleanly, any other changes needed?

[commitay]

Thanks @tylerjl!