Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 9.2.0 (devel) #21128

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Nov 28, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

npm 5.6.0 (pre-release)

CC @DomT4 @chrmoritz

@ilovezfs ilovezfs mentioned this pull request Nov 28, 2017
4 tasks
npm 5.6.0 (pre-release)
@chrmoritz
Copy link
Contributor

chrmoritz commented Nov 28, 2017

Should we apply metadata compatibility patches (to minizlib) for devel/HEAD to ensure, that a downgrade of npm to the latest stable version on npm (v5.5.1) doesn't break it for devel/HEAD or are we fine here with having this issue?

@DomT4
Copy link
Member

DomT4 commented Nov 28, 2017

The position generally on devel and HEAD is that if you broke it, you should know how to fix it, or how not to break it in the first place... otherwise you should stick to stable.

@ilovezfs
Copy link
Contributor Author

I think

brew postinstall --devel node

will fix that, right?

@chrmoritz
Copy link
Contributor

chrmoritz commented Nov 28, 2017

Yeah, brew postinstall --devel node will always work.

What I meant was basically a backwards version of #20431: Faking minizlib@1.0.4 in npm 5.6.0 to think that it is minizlib@1.0.3, so that it is reused instead of replaced with the real broken minizlib@1.0.3 version on a npm downgrade to the stable v5.5.1.

BTW: You can easily check npm info npm dist-tags.latest to see when npm@5.6.0 gets stable.

@ilovezfs
Copy link
Contributor Author

I think we can avoid that for the time being, but can reconsider if it becomes a problem.

@ilovezfs ilovezfs merged commit 3112eba into Homebrew:master Nov 28, 2017
@ilovezfs
Copy link
Contributor Author

shipped.

@chrmoritz
Copy link
Contributor

Here is the patch, that would add compatibility for downgrading npm to the latest stable version (v5.5.1) without breaking it: https://gist.github.com/chrmoritz/965365c1fbcab38720f004fa40b30a84

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants