Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tarantool: revision bump to migrate to icu4c@76 #196228

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 31, 2024

  • Migrate to icu4c@76
  • Fix Xcode 16 build
  • Remove unnecessary workarounds and CMake args
  • Install man pages in correct directory
  • Set CURL_ROOT_DIR to avoid CURL_ROOT being overridden
  • Use modern CMake commands
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the icu4c ICU use is a significant feature of the PR or issue label Oct 31, 2024
Copy link
Contributor

Hi, thanks for your contribution to Homebrew! ❤️

You already have >=15 open pull requests, so please get them ready to be merged or close them before you open more. If CI fails on any of them, please fix it or ask for help doing so.

If you are performing simple version bumps, @BrewTestBot automatically bumps a list of formulae so you don't need to. Please take a look at issues and pull requests labelled help wanted Task(s) needing PRs from the community or maintainers and see if you can help to fix any of them. Thanks!

@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 31, 2024
* Migrate to `icu4c@76`
* Fix Xcode 16 build
* Remove unnecessary workarounds and CMake args
* Install man pages in correct directory
* Set `CURL_ROOT_DIR` to avoid `CURL_ROOT` being overridden
* Use modern CMake commands
@cho-m cho-m marked this pull request as ready for review October 31, 2024 15:45
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 31, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit 7cb8d7b Oct 31, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the tarantool-icu4c76 branch October 31, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. icu4c ICU use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants