Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-revise: drop python-setuptools dependency #165370

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@ZhongRuoyu ZhongRuoyu added the python-vendoring Part of the Python resource vendoring project label Mar 7, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 7, 2024
@ZhongRuoyu ZhongRuoyu removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 7, 2024
@ZhongRuoyu ZhongRuoyu force-pushed the git-revise-setuptools branch from 8a1d564 to 5f0fcf4 Compare March 7, 2024 16:33
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 7, 2024
@ZhongRuoyu ZhongRuoyu removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 7, 2024
Comment on lines 307 to 309
"git-revise": {
"extra_packages": ["setuptools"]
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setuptools is build-only so this shouldn't be needed (our venv enables build isolation meaning pip will install it if needed):

Suggested change
"git-revise": {
"extra_packages": ["setuptools"]
},

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @branchvincent, I'll update the rest accordingly too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, there is an edge case where pip wont download setuptools if the project doesn't have a pyproject.toml, but we can workaround that with #163143 (comment)

@ZhongRuoyu ZhongRuoyu force-pushed the git-revise-setuptools branch from 5f0fcf4 to 1a48a53 Compare March 7, 2024 17:21
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Mar 7, 2024
Copy link
Contributor

github-actions bot commented Mar 7, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 7, 2024
@BrewTestBot BrewTestBot enabled auto-merge March 7, 2024 18:14
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 7, 2024
Merged via the queue into master with commit 3fb2547 Mar 7, 2024
13 checks passed
@BrewTestBot BrewTestBot deleted the git-revise-setuptools branch March 7, 2024 18:20
ZhongRuoyu added a commit that referenced this pull request Mar 7, 2024
Per #165370 (comment)
this is not necessary with a virtualenv.
ZhongRuoyu added a commit that referenced this pull request Mar 7, 2024
Per #165370 (comment)
this is not necessary with a virtualenv.
ZhongRuoyu added a commit that referenced this pull request Mar 7, 2024
Per #165370 (comment)
this is not necessary with a virtualenv.
ZhongRuoyu added a commit that referenced this pull request Mar 7, 2024
Per #165370 (comment)
this is not necessary with a virtualenv.
ZhongRuoyu added a commit that referenced this pull request Mar 7, 2024
Per #165370 (comment)
this is not necessary with a virtualenv.
ZhongRuoyu added a commit that referenced this pull request Mar 7, 2024
Per #165370 (comment)
this is not necessary with a virtualenv.
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-vendoring Part of the Python resource vendoring project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants