-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-revise: drop python-setuptools
dependency
#165370
Conversation
8a1d564
to
5f0fcf4
Compare
pypi_formula_mappings.json
Outdated
"git-revise": { | ||
"extra_packages": ["setuptools"] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setuptools
is build-only so this shouldn't be needed (our venv
enables build isolation meaning pip
will install it if needed):
"git-revise": { | |
"extra_packages": ["setuptools"] | |
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @branchvincent, I'll update the rest accordingly too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, there is an edge case where pip
wont download setuptools if the project doesn't have a pyproject.toml
, but we can workaround that with #163143 (comment)
5f0fcf4
to
1a48a53
Compare
🤖 An automated task has requested bottles to be published to this PR. |
Per #165370 (comment) this is not necessary with a virtualenv.
Per #165370 (comment) this is not necessary with a virtualenv.
Per #165370 (comment) this is not necessary with a virtualenv.
Per #165370 (comment) this is not necessary with a virtualenv.
Per #165370 (comment) this is not necessary with a virtualenv.
Per #165370 (comment) this is not necessary with a virtualenv.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?