golangci-lint 1.51.1 #122351
Closed
golangci-lint 1.51.1 #122351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
go
Closed
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a |
The issue is resolved now. relates to #122483 |
chenrui333
force-pushed
the
bump-golangci-lint-1.51.1
branch
from
dd76f99 to
2faa0e2
Compare
chenrui333
approved these changes
Feb 11, 2023
|
We should wait for Go 1.20 to make sure this will work. |
|
🤖 A scheduled task has triggered a merge. |
The formula would get revision bump to regression test against go1.20, so it should be fine. |
|
I am referring to this commit |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with
brew bump-formula-pr.Note: according to golangci/golangci-lint#3565, golangci-lint 1.51.0 and this PR are currently broken when built on Go 1.19 and used with Go 1.20.
This PR hence depends on #122082.