Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 7.7.0 #10469

Closed
wants to merge 1 commit into from
Closed

node 7.7.0 #10469

wants to merge 1 commit into from

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Mar 1, 2017

Created with brew bump-formula-pr.

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Mar 1, 2017

@DomT4 any idea what's going on here?

@DomT4
Copy link
Member

DomT4 commented Mar 1, 2017

In file included from ../node_modules/nan/nan.h:47:
/Users/xyz/.node-gyp/7.7.0/include/node/node.h:44:10: fatal error: 'tracing/trace_event.h' file not found
#include "tracing/trace_event.h"
         ^
1 error generated.
make: *** [Release/obj.target/bignum/bignum.o] Error 1
gyp ERR! build error

nodejs/node#11628

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Mar 1, 2017

Thanks @DomT4 ... it's vaguely disturbing our CI caught this and theirs, not so much.

@DomT4
Copy link
Member

DomT4 commented Mar 1, 2017

I presume there will be a new release cut very soon at least. This will be quite the unpleasant surprise to anyone who automatically goes "Ooh new node release, let's update" and then tries to install anything that uses node-gyp 😕.

@JCount
Copy link
Contributor

JCount commented Mar 1, 2017

pending PR with cherry-picked fix, slated for a quick 7.7.1 release: nodejs/node#11634

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Mar 1, 2017

At least someone is asking the "right" question: nodejs/node#11634 (comment)

@DomT4
Copy link
Member

DomT4 commented Mar 1, 2017

Heads up when there is a new release cut the test do block could do with tweaking as well. Nobody is currently running that full localisation test because the "full-icu" option no longer exists.

@JCount JCount added do not merge upstream issue An upstream issue report is needed labels Mar 2, 2017
@JCount
Copy link
Contributor

JCount commented Mar 2, 2017

superseded by #10497

@JCount JCount closed this Mar 2, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants