-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redis@6.2 6.2.7 (new formula) #102258
redis@6.2 6.2.7 (new formula) #102258
Conversation
Please indicate how this would fill our criteria for versioned formulas (https://docs.brew.sh/Versions) and why we might want to ship an older version? |
Thanks for taking a look at this pull request. Redis 7.0 introduces a number of potentially breaking changes, as documented in the release notes. For example, the response structure of an important command for using Redis in clustered mode has changed and hence is not currently compatible with certain clients, such as go-redis/redis which is imported by 3,796 public modules at time of writing. Redis 6.2 is the previous There are also existing versioned formulae for redis@4.0 and redis@3.2 I've had a read through the list of requirements and believe that this formula meets them, but if there's anything that might have been missed, I'd be happy to provide further details. |
Looking at the document, can you add a |
ping @JamieEdge |
Apologies for the delayed response. Before committing this change, please could I ask how the disable date would be calculated for this formula? My understanding is that Redis 6.2 will receive maintenance updates until the release of Redis 8.0. I was not able to find a provisional release date for this next major release. |
https://redis.io/docs/about/releases/#release-schedule suggests a major release every year, and a minor release in 6 months. So support will be:
|
Thanks, that makes sense. I have applied all suggestions now. |
Thanks @JamieEdge! Without contributions like yours, it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉 |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Redis 7.0, added in #100324, introduces a number of potentially breaking changes. For example, the Go client is not yet fully compatible (redis/go-redis#2082).
This pull request adds a formula for the previous major version based on redis.rb.