Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman-desktop 1.8.0 #169041

Merged

Conversation

podman-desktop-bot
Copy link
Contributor

Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Mar 14, 2024
@razvanazamfirei razvanazamfirei added the ci-requeue [DEPRECATED] Triggers a CI re-run when applied. label Mar 15, 2024
@BrewTestBot BrewTestBot removed the ci-requeue [DEPRECATED] Triggers a CI re-run when applied. label Mar 15, 2024
@cdrage
Copy link

cdrage commented Mar 15, 2024

Hi, looks like false positives? Any way to re-run the tests @chenrui333

@benoitf benoitf force-pushed the bump-podman-desktop-1.8.0 branch 2 times, most recently from 76ed037 to 866cebe Compare March 15, 2024 14:41
@benoitf
Copy link
Contributor

benoitf commented Mar 15, 2024

PR has been rebased but it's failing on python side

Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3
Target /usr/local/bin/2to3
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3'
To force the link and overwrite all conflicting files:
  brew link --overwrite python@3.12
To list all files that would be deleted:
  brew link --overwrite python@3.12 --dry-run

@krehel krehel mentioned this pull request Mar 15, 2024
@p-linnane p-linnane requested a review from a team March 15, 2024 23:09
@p-linnane p-linnane added the awaiting maintainer feedback Issue needs response from a maintainer. label Mar 15, 2024
@daeho-ro
Copy link
Sponsor Contributor

daeho-ro commented Mar 17, 2024

There is a version compatibility issue between CI image for intel mac and homebrew. actions/setup-python#577

I am not fully understand the issue, but recently there is an update for the python@3.12 on the homebrew-core where the version from 3.12.1 to 3.12.2. Homebrew/homebrew-core#162003

However, the github action runner for macOS-13 is not yet updated and remains 3.12.1.
https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md
The version update PR is ready. actions/runner-images#9375

@krehel
Copy link
Member

krehel commented Mar 17, 2024

@Bo98 is this something you can help with?

@Bo98
Copy link
Member

Bo98 commented Mar 19, 2024

Yeah this has been a long standing bug on GitHub's side.

We do have a brew unlink python && brew link --overwrite python workaround, but it temporarily doesn't work because the GitHub images haven't been updated in a while now and we switched 3.11 to 3.12 by default since (it should work again when the next image is pushed). Temproarily making it python@3.11 will fix it, though maybe there's something more dynamic we can do - or just uninstall the non-Homebrew Python entirely.

@Bo98
Copy link
Member

Bo98 commented Mar 19, 2024

Replacing it with rm -rf /Library/Frameworks/Python.framework && brew cleanup --prune-prefix might work?

Anka and others added 2 commits March 19, 2024 12:06
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Podman can be installed from the UI of Podman Desktop anyway
@benoitf
Copy link
Contributor

benoitf commented Mar 19, 2024

I've removed the dependency to podman cask as Podman-Desktop can run without it and it provides also an option to install podman.

it'll probably workaround python@3.12 issue

@benoitf
Copy link
Contributor

benoitf commented Mar 19, 2024

@chenrui333 is it ok for you ?

@benoitf
Copy link
Contributor

benoitf commented Mar 19, 2024

@p-linnane looks like by cutting the dependency now it's OK

@p-linnane p-linnane removed the awaiting maintainer feedback Issue needs response from a maintainer. label Mar 20, 2024
@p-linnane p-linnane merged commit 3c803b0 into Homebrew:master Mar 20, 2024
11 checks passed
@benoitf benoitf deleted the bump-podman-desktop-1.8.0 branch March 20, 2024 20:31
github-actions bot pushed a commit to MPLew-is/homebrew-vscodium that referenced this pull request Mar 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-cask-pr PR was created using `brew bump-cask-pr` outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants