Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Synth1 Audio Unit and VST #15644

Closed
wants to merge 2 commits into from
Closed

Conversation

joshka
Copy link
Contributor

@joshka joshka commented Dec 6, 2015

Includes the new artifacts to represent a symlink to the ~/Library/Audio/Plug-Ins/{VST,Components} folders.

Joshua McKinney added 2 commits December 6, 2015 16:26
These are two seperate casks of the same plugin. One for the Audio Unit, and one for the VST.
Neither is the main type as each DAW (Ableton Live, Cubase, Apple Logic, etc.) may use one or the other.
@adidalal
Copy link
Contributor

adidalal commented Dec 7, 2015

On hold until #15643 is merged.

The PR will likely need to be redone at that point so that only the two synth1-Cask related files are modified.

@joshka
Copy link
Contributor Author

joshka commented Dec 7, 2015

Gotcha - thanks.

@adidalal
Copy link
Contributor

@joshka #15643 is now merged and the documentation updated accordingly.

Please either rebase or make a new PR with only the two Cask files - synth1-au.rb and synth1-vst.rb.

Additionally, please change the cask header lines.
Example: cask 'dropbox' do

Also I noticed you were using joshka.github.fake@joshka.net.fake as the commit email. If you change your local git commit email to joshka@users.noreply.github.com, it will link your commits to your Github user page properly, while still hiding your email address.

@adidalal adidalal added the awaiting user reply Issue needs response from a user. label Dec 16, 2015
@jawshooah
Copy link
Contributor

Thank you for the contribution. It needed some fixes, so they were made in abe5fa7. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

@jawshooah jawshooah closed this Dec 22, 2015
@joshka
Copy link
Contributor Author

joshka commented Dec 24, 2015

Thanks guys

@adidalal adidalal removed the awaiting user reply Issue needs response from a user. label Jan 3, 2016
@joshka joshka deleted the feature/synth1 branch January 9, 2016 19:50
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants