Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -- for bottles. #4612

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Aug 6, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Use -- for bottles so they can be dropped into the cache.

Fixes #4601 (comment).

@ghost ghost assigned reitermarkus Aug 6, 2018
@ghost ghost added the in progress Maintainers are working on this label Aug 6, 2018
@ilovezfs
Copy link
Contributor

ilovezfs commented Aug 6, 2018

Thank you!

@reitermarkus reitermarkus force-pushed the bottle-double-dash branch 3 times, most recently from f87648e to f09ccee Compare August 6, 2018 15:32
@reitermarkus reitermarkus merged commit 93faf44 into Homebrew:master Aug 6, 2018
@reitermarkus reitermarkus deleted the bottle-double-dash branch August 6, 2018 16:15
@ghost ghost removed the in progress Maintainers are working on this label Aug 6, 2018
@jonchang jonchang mentioned this pull request Aug 7, 2018
2 tasks
@lock lock bot added the outdated PR was locked due to age label Sep 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants