Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream.rbi: remove Fiddle constants #18502

Merged
merged 1 commit into from
Oct 4, 2024
Merged

upstream.rbi: remove Fiddle constants #18502

merged 1 commit into from
Oct 4, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Oct 4, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

These should no longer be needed after #18501.

These should no longer be needed after #18501.
Base automatically changed from dependabot/bundler/Library/Homebrew/sorbet-0.5.11595 to master October 4, 2024 07:35
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlocab!

@carlocab carlocab merged commit 7752457 into master Oct 4, 2024
25 checks passed
@carlocab carlocab deleted the rm-upstream-rbi branch October 4, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants