-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audit: audit deprecate/disable reasons #18463
audit: audit deprecate/disable reasons #18463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could this be a shared audit and used for both? The code will be near identical.
b30e21d
to
53e8739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, thanks for implementing formulae too @bevanjkay!
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This adds a shared audit for Formulae & Casks that checks the validity of deprecation/disable reasons.