Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On travis-ci pkg-config can't find zlib #563

Closed
sledgehammer999 opened this issue Jul 20, 2016 · 5 comments
Closed

On travis-ci pkg-config can't find zlib #563

sledgehammer999 opened this issue Jul 20, 2016 · 5 comments

Comments

@sledgehammer999
Copy link

First of all sorry if this isn't the correct place to report this. Also I am not entirely sure that this is a homebrew problem.

I am the maintainer of qBittorrent. We have set up our travis.yml to do OS X builds a long time ago. Up until now everything went ok. But the last few days( or weeks) our configure script complains that it cannot find zlib. So I assume that something changed in newer versions of homebrew.

  1. We didn't change our travis.yml before this failure
  2. We didn't change our configure script before this failure
  3. The configure script uses pkg-config macros to query for packages(and for zlib)
  4. We don't install the zlib package from homebrew. We use the system one. On my system the configure script works great in this way. But I can't figure out why it fails on a clean system(aka travis-ci).

Do you guys have any insight on how to solve this?

Here is the latest travis failure: https://travis-ci.org/qbittorrent/qBittorrent/jobs/146165871
Here is our travis.yml: https://github.com/qbittorrent/qBittorrent/blob/master/.travis.yml

@scpeters
Copy link
Contributor

This sounds like #539 and Homebrew/homebrew-core#3051

Sorry I don't have a specific suggestion, but you might find clues in those other issues.

@DomT4
Copy link
Contributor

DomT4 commented Jul 20, 2016

See also: travis-ci/travis-ci#6329

We recommend people add something like:

brew outdated "pkg-config" || brew upgrade "pkg-config"

To their Travis scripts. We're attempting to make Homebrew more cross-platform, which has involved moving some elements around. Sadly Travis doesn't routinely update the dependencies shipped on their boxes automatically, which is problematic in multiple ways for us but I understand the logic behind it.

Apologies on our side that us moving things around can be annoying. The end product will be useful to more people & help various projects (Linuxbrew, Homebrew, Tigerbrew, Caskroom) share the same core (non-formula) code rather than maintaining unique forks, but it's not entirely painless getting there.

We don't install the zlib package from homebrew. We use the system one.

OS X doesn't bother providing a pkg-config file for zlib or various other things, despite plenty of projects expecting to find it that way. Consequently, things that use pkg-config to find system dependencies on OS X can end up relying on Homebrew's vendored .pc files to do so. That will be the case here.

@DomT4 DomT4 closed this as completed Jul 20, 2016
@MikeMcQuaid
Copy link
Member

Once we hit Homebrew 1.0 (coming soon!) this will hopefully stabilise a bit and we can request some of these images get recreated.

sledgehammer999 added a commit to qbittorrent/qBittorrent that referenced this issue Jul 21, 2016
Fixes 'zlib not found` errors.
Details: Homebrew/brew#563
@sledgehammer999
Copy link
Author

brew outdated "pkg-config" || brew upgrade "pkg-config"

👍 Yup this works. I hadn't realized that homebrew preinstalls pkg-config and that we need to upgrade it manually.

@DomT4
Copy link
Contributor

DomT4 commented Jul 21, 2016

We don't, but Travis preinstalls a bunch of formulae for user convenience.

sledgehammer999 added a commit to qbittorrent/qBittorrent that referenced this issue Sep 8, 2016
Fixes 'zlib not found` errors.
Details: Homebrew/brew#563
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants