Use localForage #16
Open
Use localForage #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-decker
approved these changes
Nov 3, 2016
|
lgtm 👍 I'm gonna wait for @aweary to jump on this as well. |
aweary
suggested changes
Nov 3, 2016
| @@ -20,9 +22,8 @@ export default class CacheWriter { | |||
| constructor(options: CacheWriterOptions = {}) { | |||
| this.cacheKey = options.cacheKey || DEFAULT_CACHE_KEY | |||
| try { | |||
| let localCache = localStorage.getItem(this.cacheKey); | |||
| let localCache = localForage.getItem(this.cacheKey); | |||
There was a problem hiding this comment.
localForage is async, so it's not a drop in replacement for localStorage. Lets go ahead and use their Promise API.
localForage.getItem(this.cacheKey)
.then(localCache => {
if (!localCache) {
this.cache = new CacheRecordStore();
} else {
this.cache = CacheRecordStore.fromJSON(localCache)
}
})
.catch(err => this.cache = new CacheRecordStore())| @@ -33,7 +34,7 @@ export default class CacheWriter { | |||
| } | |||
|
|
|||
| clearStorage() { | |||
| localStorage.removeItem(this.cacheKey); | |||
| localForage.removeItem(this.cacheKey); | |||
There was a problem hiding this comment.
Same here, lets use the Promise API to reset this.cache after this key has been removed.
| @@ -53,8 +54,7 @@ export default class CacheWriter { | |||
| record[field] = value; | |||
| this.cache.records[dataId] = record; | |||
| try { | |||
| const serialized = JSON.stringify(this.cache); | |||
| localStorage.setItem(this.cacheKey, serialized); | |||
| localForage.setItem(this.cacheKey, this.cache); | |||
There was a problem hiding this comment.
We can move this out of the try / catch since its async
| @@ -20,9 +22,8 @@ export default class CacheWriter { | |||
| constructor(options: CacheWriterOptions = {}) { | |||
| this.cacheKey = options.cacheKey || DEFAULT_CACHE_KEY | |||
There was a problem hiding this comment.
You need to call localforage.config before using it, so lets let users pass in their own config for this, and default to an empty object.
localForage.config(options.localForage || {});
|
Thanks for the feedback @aweary, pushed a commit addressing your points 👍 let me know if it looks good |
|
Hey @aweary any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1 and #15 by using
localForageinstead oflocalStorage.Also updated the
relay-starter-kitexample to latest and the usage of the cache manager to reflect the exposedinjectCacheManagermethod on theRelayEnvironment(cf. facebook/relay#1320)