Skip to content

Commit

Permalink
Release v1.1.1
Browse files Browse the repository at this point in the history
** Bugs
    * [HICO-40627] - Text settings not changed in edit mode (analysis mode correct)
    * [HICO-40646] - JS-Exception while migration from v.1.0.4 to v1.1.0
  • Loading branch information
HighCoordination committed Jan 18, 2018
1 parent a481bc8 commit e4c135a
Show file tree
Hide file tree
Showing 5 changed files with 68 additions and 29 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "truechart-menubar",
"version": "1.1.0",
"version": "1.1.1",
"description": "trueChart-Menubar as visualization extension for Qlik Sense® allows for vertical and horizontal buttons and selections (fields, master dimensions and variables) as well as unlimited trigger based Actions. #trueChart #trueChart-Menubar #highcoordination",
"main": "tcmenu.js",
"keywords": [
Expand Down
14 changes: 12 additions & 2 deletions resource/RELEASE_NOTES.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,17 @@
trueChart-Menubar v1.1.1
====================================================================================
++ DATE: 2018-1-18
++ BUILD: v1.1.1_159
++ DESCRIPTION: trueChart-Menubar v1.1.1 (v1.1 Service Release 1)

** Bugs
* [HICO-40627] - Text settings not changed in edit mode (analysis mode correct)
* [HICO-40646] - JS-Exception while migration from v.1.0.4 to v1.1.0

trueChart-Menubar v1.1.0
====================================================================================
++ DATE: ##DATE##
++ BUILD: v1.1.0_##BUILD_NUMBER##
++ DATE: 2018-1-4
++ BUILD: v1.1.0_156
++ DESCRIPTION: trueChart-Menubar v1.1.0 (v1.1 Major Release - Export & master, drill down & expression-based dimension support)

** Features and Improvements
Expand Down
40 changes: 31 additions & 9 deletions src/doc/tcmenu.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,6 @@ An upgrade to the current version requires a migration. If this migration is not
* [HICO-40461] - New position of edit button state in properties panel
* [HICO-40463] - Performance: Reduced intial loading time (due to reduced count of extension assets)

==== Bugfixes

* [HICO-2726] - Menubar destroys representation of Sense filter pane objects in same sheet
* [HICO-2905] - Button+ UI code editor not working
* [HICO-2939] - [JS-Exception] due to incorrect default value expressions in single select items
* [HICO-40454] - Custom actions are not visible initially after reopening button+ editor
* [HICO-40487] - [JS-Exception] TypeError: Cannot read property 'layout' of undefined

==== Migrate to {tcmenu} ##VERSION

The new {tcmenu} release introduces the support of master and dynamic dimensions.
Expand Down Expand Up @@ -643,9 +635,39 @@ Additionally, in the case of publicated apps, it is neccessary to create a corre

<<<
[appendix]
== Previous Releases
== Releases Notes

:sectnums!:
=== {tcmenu} v1.1.1

DATE: 2018-1-18

** Bugs
* [HICO-40627] - Text settings not changed in edit mode (analysis mode correct)
* [HICO-40646] - JS-Exception while migration from v.1.0.4 to v1.1.0

=== {tcmenu} v1.1.0

DATE: 2018-1-4

** Features and Improvements
* [HICO-2178] - Support of Sense PDF export function for TC-Menu
* [HICO-2524] - Improvement when using master item dimensions and expression-based dimensions
* [HICO-2560] - Support of DrillDown-dimensions in selections (Single, Sense and Multi)
* [HICO-2601] - Specify expressions for dimension defintion directly
* [HICO-2889] - Option to enter title, subtitle or footnote
* [HICO-2890] - Conditional display and hiding of menu elements
* [HICO-40445] - Mark button+ actions for sequential or parallel execution (Execute in order)
* [HICO-40461] - New position of edit button state in properties panel
* [HICO-40463] - Performance: Reduced initial loading time (due to reduced count of extension assets)

** Bugs
* [HICO-2726] - Menubar destroys representation of Sense filter pane objects in same sheet
* [HICO-2905] - Button+ UI code editor not working
* [HICO-2939] - [JS-Exception] due to incorrect default value expressions in single select items
* [HICO-40454] - Custom actions are not visible initially after reopening button+ editor
* [HICO-40487] - [JS-Exception] TypeError: Cannot read property 'layout' of undefined

=== {tcmenu} v1.0.8

DATE: 2017-11-22
Expand Down
12 changes: 7 additions & 5 deletions src/js/Services/UpdateService.js
Original file line number Diff line number Diff line change
Expand Up @@ -242,18 +242,20 @@ export default class UpdateService {
qData: {dimId: '/dimId', listDef: '/listDef', listLibId: '/listLibId'}
};

// we can stop here, if we do not have any dimensions to update
if(!properties.dimensions){
return Promise.resolve(updateObject);
}

// add new property "Show Condition"
(properties.listItems || []).forEach(listItem =>{
if(listItem.showCondition === undefined){
listItem.showCondition = '';
}
});

// we can stop here, if we do not have any dimensions to update
if(!properties.dimensions || !properties.dimensions.length){
properties.dimensions = []; // make sure we have a valid dimensions array
updateObject.listObjects = [];
return Promise.resolve(updateObject);
}

// ensure correct mapping between dimensions and listItems by using dimensions cId as unique key
updateDimensions(properties);

Expand Down
29 changes: 17 additions & 12 deletions src/js/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export function Extension(){
let _app = qlik.currApp(/*$scope*/), // reference must have backandApi as property ($scope -> backendApi -> model)
_waitForUpdates, // Promise, which will be resolved, when updates are finished
_model = $scope.backendApi.model,
_originalModel = $scope.backendApi.model,
_waitForVariable = qlik.Promise.resolve(),
_selectionsInProgress = false,
_ready = qlik.Promise.defer(),
Expand Down Expand Up @@ -129,6 +130,21 @@ export function Extension(){

//##################### Initialization #####################
_waitForUpdates.then(updateObj =>{
if(updateObj.isUpdatable === false){
// update isUpdatable property with "real" values. In case of required updates, but not updatable model (published app) it will be false
$scope.isUpdatable = updateObj.isUpdatable;

// use updated model in case of not updatable extension
_model = updateObj.model;

// use layout from updated model (session object) in case of no updatable model, otherwise it comes from scopes prototype
$scope.layout = _model.layout;

return updateObj;
}else{
return qlikService.getLayout(_model).then(() => updateObj);
}
}).then(updateObj =>{
if($scope.isPrinting){
$scope.initReady = true;
return; // in case of printing, nothing more to do
Expand All @@ -140,18 +156,7 @@ export function Extension(){
let listObjects = updateObj.listObjects,
objectIds = listObjects
? listObjects.map(obj => obj.id)
: _model.layout.qChildList.qItems.map(item => item.qInfo.qId);

if(typeof updateObj.isUpdatable === 'boolean'){
// update isUpdatable property with "real" values. In case of required updates, but not updatable model (published app) it will be false
$scope.isUpdatable = updateObj.isUpdatable;

// use updated model in case of not updatable extension
_model = updateObj.model;

// use layout from updated model (session object) in case of no updatable model, otherwise it comes from scopes prototype
$scope.layout = _model.layout;
}
: _originalModel.layout.qChildList.qItems.map(item => item.qInfo.qId);

// set active select items
setSelectItems($scope, $scope.layout.listItems);
Expand Down

0 comments on commit e4c135a

Please sign in to comment.