-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move 8.1.5 to main for autoupdater #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [Autoupdater.NET.Official](https://github.com/ravibpatel/AutoUpdater.NET) from 1.8.4 to 1.8.5. - [Release notes](https://github.com/ravibpatel/AutoUpdater.NET/releases) - [Commits](ravibpatel/AutoUpdater.NET@v1.8.4...v1.8.5) --- updated-dependencies: - dependency-name: Autoupdater.NET.Official dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* Delete .nuget/packages.config Remove hopefully obsolete package list confusing dependency tracking * Remove .nuget folder --------- Co-authored-by: James A Sutherland <>
Bumps [shogo82148/actions-setup-perl](https://github.com/shogo82148/actions-setup-perl) from 1.28.0 to 1.29.0. - [Release notes](https://github.com/shogo82148/actions-setup-perl/releases) - [Commits](shogo82148/actions-setup-perl@v1.28.0...v1.29.0) --- updated-dependencies: - dependency-name: shogo82148/actions-setup-perl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James Friel <jfriel001@dundee.ac.uk>
Bumps [CsvHelper](https://github.com/JoshClose/CsvHelper) from 30.0.3 to 30.1.0. - [Commits](JoshClose/CsvHelper@30.0.3...30.1.0) --- updated-dependencies: - dependency-name: CsvHelper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: James Friel <jfriel001@dundee.ac.uk>
Bumps [SSH.NET](https://github.com/sshnet/SSH.NET) from 2023.0.1 to 2024.0.0. - [Release notes](https://github.com/sshnet/SSH.NET/releases) - [Commits](sshnet/SSH.NET@2023.0.1...2024.0.0) --- updated-dependencies: - dependency-name: SSH.NET dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [SixLabors.ImageSharp.Drawing](https://github.com/SixLabors/ImageSharp.Drawing) from 2.1.0 to 2.1.1. - [Release notes](https://github.com/SixLabors/ImageSharp.Drawing/releases) - [Commits](SixLabors/ImageSharp.Drawing@v2.1.0...v2.1.1) --- updated-dependencies: - dependency-name: SixLabors.ImageSharp.Drawing dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [MongoDB.Driver](https://github.com/mongodb/mongo-csharp-driver) from 2.23.1 to 2.24.0. - [Release notes](https://github.com/mongodb/mongo-csharp-driver/releases) - [Commits](mongodb/mongo-csharp-driver@v2.23.1...v2.24.0) --- updated-dependencies: - dependency-name: MongoDB.Driver dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [NUnit](https://github.com/nunit/nunit) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/nunit/nunit/releases) - [Changelog](https://github.com/nunit/nunit/blob/master/CHANGES.md) - [Commits](nunit/nunit@v4.0.1...4.1.0) --- updated-dependencies: - dependency-name: NUnit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [FluentFTP](https://github.com/robinrodricks/FluentFTP) from 49.0.1 to 49.0.2. - [Release notes](https://github.com/robinrodricks/FluentFTP/releases) - [Changelog](https://github.com/robinrodricks/FluentFTP/blob/master/RELEASES.md) - [Commits](https://github.com/robinrodricks/FluentFTP/commits) --- updated-dependencies: - dependency-name: FluentFTP dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* centrally managed dependacies * add directory.project.props file * fix typo * fix build * fix up test * Whitespace cleanup * Avoid searching for and reading all csproj files twice * remove console log * update dependabot actions * remove dependabot lower bounds --------- Co-authored-by: James A Sutherland <>
Bumps [YamlDotNet](https://github.com/aaubry/YamlDotNet) from 15.1.1 to 15.1.2. - [Release notes](https://github.com/aaubry/YamlDotNet/releases) - [Commits](aaubry/YamlDotNet@v15.1.1...v15.1.2) --- updated-dependencies: - dependency-name: YamlDotNet dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…sl/RDMP-121-upgrade-net-8
Task/rdmp-121 Upgrade to .net8
Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/coverlet-coverage/coverlet/releases) - [Commits](coverlet-coverage/coverlet@v6.0.0...v6.0.1) --- updated-dependencies: - dependency-name: coverlet.collector dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update excel attacher processing ordering
Bumps [SixLabors.ImageSharp](https://github.com/SixLabors/ImageSharp) from 3.1.2 to 3.1.3. - [Release notes](https://github.com/SixLabors/ImageSharp/releases) - [Commits](SixLabors/ImageSharp@v3.1.2...v3.1.3) --- updated-dependencies: - dependency-name: SixLabors.ImageSharp dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [SixLabors.ImageSharp.Drawing](https://github.com/SixLabors/ImageSharp.Drawing) from 2.1.1 to 2.1.2. - [Release notes](https://github.com/SixLabors/ImageSharp.Drawing/releases) - [Commits](SixLabors/ImageSharp.Drawing@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: SixLabors.ImageSharp.Drawing dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [NUnit.Analyzers](https://github.com/nunit/nunit.analyzers) from 4.0.1 to 4.1.0. - [Release notes](https://github.com/nunit/nunit.analyzers/releases) - [Changelog](https://github.com/nunit/nunit.analyzers/blob/master/CHANGES.txt) - [Commits](nunit/nunit.analyzers@4.0.1...4.1.0) --- updated-dependencies: - dependency-name: NUnit.Analyzers dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [HIC.BadMedicine](https://github.com/HicServices/BadMedicine) from 1.2.0 to 1.2.1. - [Release notes](https://github.com/HicServices/BadMedicine/releases) - [Changelog](https://github.com/HicServices/BadMedicine/blob/develop/CHANGELOG.md) - [Commits](HicServices/SynthEHR@v1.2.0...v1.2.1) --- updated-dependencies: - dependency-name: HIC.BadMedicine dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* bring notification to front * add top most
Bumps [NPOI](https://github.com/nissl-lab/npoi) from 2.6.2 to 2.7.0. - [Release notes](https://github.com/nissl-lab/npoi/releases) - [Commits](https://github.com/nissl-lab/npoi/commits) --- updated-dependencies: - dependency-name: NPOI dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix value to string conversion * Update ExcelDataFlowSource.cs
* extractions remember pipeline * update changelog * reorder testing * fix test * revert test * add order to test * updates from codeql * tidy up code * Update ExecuteExtractionUI.cs
* add 50min timeout * interim * add optional timeout * add changelog * tidy up from codeql * update
* improve bak file usage * add documentation stub * add docs * tidy up code * bump sixLabors * update to ui * restore files * improve documentation * add using statement
…olumn Task/RDMP-154 Cohort Importer respects remote server ID
* start of msi upgrade * remove wix * update build steps * tidy up * restore file * update sln
* basic db objects * fix typo * working db linkage * working build * add sql update * update sql * update tests * update sql * update create sql * update sql * update sql * update class * fix extra space * attempt to fix tests * remove linkage * fix typo * add test case * attempt image fix * fix up image * add missing file * add changelog * interim * interim * tidy up code * fix build * icons * rename icon file (#1755) * working icon * update create sql * update patch * add patch * working patches * add basic tests * tidy up code * add go * attempt to fix patch * tidy up code * remove true equal true check * tidy up from review * update migration * remove dupe file (#1774) * fix build * interim sql * update patch * fix sql patch * update patch id * update patch id * fix bad merge * tidy up code * tidy up code --------- Co-authored-by: James A Sutherland <j.a.sutherland@dundee.ac.uk>
…switch Task/RDMP-160 Fix Bad Logic Check
…sk/RDMP-156-prep-8.1.5-release
* add release date * update changelog
…sk/RDMP-156-prep-8.1.5-release
…lease Task/rdmp 156 prep 8.1.5 release
* disable tag check * add sgen * revert bad fix * nudge deps * fix duplicate deps * drop dep * fix build
Comment on lines
+179
to
+186
if (!string.IsNullOrWhiteSpace(Timeout) && int.TryParse(Timeout, out var _timeout)) | ||
{ | ||
builder["Timeout"] = _timeout; | ||
} | ||
else | ||
{ | ||
builder["Timeout"] = 30000; | ||
} |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.