Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value limits to GPS coordinates for Configurations #410

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

153957
Copy link
Member

@153957 153957 commented Oct 14, 2024

Relevant for Station 601 which currently reports:

gps_altitude: -Infinity,
gps_latitude: Infinity,
gps_longitude: 5.000000000000011,

This would make this config invalid because the latitude is invalid.

Note; will need to generate a database migration before merging.

Commonly longitude would be limited to -180° to 180°, but I think its fine to allowed -360° to 360°

@153957
Copy link
Member Author

153957 commented Oct 14, 2024

The config from 601 is causing issues in daily updated when trying to determine detector timing offsets when creating Station objects in SAPPHiRE.
I think this can be solved by preventing the invalid coordinates from appearing in the publicdb API.
SAPPHiRE can also be made more robust and validate provided coordinates, I guess it kind of does since it raises and exception... so we should just prevent the location from being allowed in pubclidb.

Copy link
Member

@davidfokkema davidfokkema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to prevent the configs from being recorded in the public database!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants