Fixed median() to handle unsorted data. Minor text changes for consistency #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for your feedback, and your PR. |
|
Ehi @keatis ,thank you for your feedback, your effort and your proactivity in creating this PR. |
|
Thank you too, @roberto-butti. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Turned out that
median()did not sort an array, thus giving wrong result on unsorted data.So, this PR is to fix this -
median()will now sort data on self behalf, likequantiles()do.Tests are included (I also made some text changes to look more consistent over that test file).
Thanks.