-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropped support for PHP 8.0 and updated Pest to v2 #36
Conversation
Hi @AmooAti thank you for this great PR.
So I can follow one of the two approaches.
As you mention, for the single responsibility of the PR, i would prefer the first option. |
Hi @roberto-butti, |
Totally agree with you, and thank you for the feedback @AmooAti @AmooAti can I ask you a favor before i merge the PR: could you decrease the level of PHPstan , form level 9 to level 8 in the githubactions? |
@roberto-butti |
@AmooAti this is great! thank you for your contribution. I'm going to merge it |
Hi,
Hope you're doing well.
In this PR, I changed the minimum PHP version to 8.1 and updated Pest PHP to version 2 (Closes #33).
Since Pest 2 uses PHPUnit v10, we had to update the old
phpunit.xml
to match the newer version's settings. I used./vendor/bin/pest --migrate-configuration
command to upgrade the file. I also removed some settings likestopOnFailure
andprocessIsolation
since they were set to the default value of PHPUnit.I understand the concept of mono PR, but on the way to updating, I fixed a function's doctype and ran the format script. :D