Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix french missing translations #892

Merged
merged 4 commits into from
Nov 21, 2024
Merged

fix french missing translations #892

merged 4 commits into from
Nov 21, 2024

Conversation

nlaburu
Copy link
Contributor

@nlaburu nlaburu commented Nov 20, 2024

Issue #870

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nlaburu nlaburu mentioned this pull request Nov 20, 2024
Closed
@jelveh
Copy link
Contributor

jelveh commented Nov 21, 2024

Hi @nlaburu, thank you very much for your contribution.

A few of the original texts have placeholders in them (%strong%) which are missing in the PR.

For example:

"unzipping": undefined, // In English: "Unzipping %strong%"

was translated to

"unzipping": 'décomprésser',

omitting the %strong% placeholder.

Could you please look into those before I can merge your PR?

Thank you

@nlaburu
Copy link
Contributor Author

nlaburu commented Nov 21, 2024

Hi @jelveh, I have fixed the error.
Thanks,

@jelveh jelveh merged commit 14f52bc into HeyPuter:main Nov 21, 2024
1 check passed
@jelveh
Copy link
Contributor

jelveh commented Nov 21, 2024

Merged. Thank you for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlaburu @CLAassistant @jelveh