Parse BRW Stats #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joehandzik this is a pretty big refactor, so please let me know if you want me to change anything and I will be glad to do so. |
|
Forgot to mention I need to add the help text still. I just want to leave this here in case you have any thoughts on the current structure. ToDo:
|
joehandzik
reviewed
Apr 4, 2017
sources/procfs.go
Outdated
| @@ -63,6 +63,7 @@ func (s *lustreSource) generateOSSMetricTemplates() error { | |||
| "obdfilter/*": map[string]string{ | |||
| "blocksize": "Filesystem block size in bytes", | |||
| "brw_size": "Block read/write size in bytes", | |||
| "brw_stats": "A collection of block read/write statistrics", | |||
|
It looks pretty good so far, but I'll come back to it a few times today to see if I have any useful suggestions. Clearly, some of these files are a pain to parse. |
|
Sounds good! Agreed. But in the case with this file, the reward is very much worth it as I'm able to scrape some really useful data about the cluster. |
added 3 commits
April 4, 2017 15:54
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
A new metric description needed to be created for block read/write stats due to the various sub-labels for each metric. In the original 'constMetric' description, only the nodeName (OST, MGT or MDT) was a sub-label. For the various BRW stats to be included with this, a new metric would need to be created for every size and operation. For example, the 'discontiguous pages' metric with a size of '1' and operation of 'read' would require a different metric from 'discontiguous pages' with a size of '1' and operation of 'write'. The new 'brwMetric' description includes sub-labels for 'size' and 'operation' to allow similar metrics to be grouped together, minimizing clutter. Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
|
Help text is added and it compiles and runs as expected! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Block Read/Write (BRW) stats file includes the following (paraphrased from the Lustre manual)