Add Megacheck

[mjtrangoni]

Hi,
I just found megacheck as a part of the go-tools project and wanted to give it a try.

As you can see above, this seems to be worth.

$ make
>> formatting code
>> vetting code
>> megacheck code
sources/procfs.go:84:2: field subsystem is unused (U1000)
sources/procfs.go:534:3: should replace loop with metricList = append(metricList, statsList...) (S1011)
sources/procfs.go:623:3: should replace loop with metricList = append(metricList, jobList...) (S1011)
sources/procfs.go:714:22: this value of err is never used (SA4006)
sources/procfs_test.go:207:2: this value of metricList is never used (SA4006)
sources/source.go:31:6: type typedDesc is unused (U1000)
Makefile:39: recipe for target 'megacheck' failed
make: *** [megacheck] Error 1

See also,

• gosimple#checks
• staticcheck#checks

This could be integrated to the project, of course after resolving the issues, if you are interested.

[roclark]

Hey @mjtrangoni this looks cool, thanks for sharing! I definitely see value in adding this, though this PR could use a bit of cleaning. First, do you mind rebasing against the master branch of this upstream repository and adding the single commit (looks like you are adding just one new commit, though I could be wrong). Second, looks like the Travis check is failing as it is unable to run megacheck. Do you mind adding another commit to edit the travis.yml file?

Thanks! I'm excited about this - let me know if you have any questions.

[mjtrangoni]

Hi @roclark,
It was my fault, sorry! The PR is now rebased against the upstream master branch, and travis is failing as I expected because of the megacheck findings listed above.

[roclark]

No worries! Looks much better now! And yes, Travis failing in this case is expected. I will let @joehandzik voice his opinion as well, but I might hold off on merging this until we at least have a fix for these issues in the works or merged - if at the very least to minimize (or prevent) the time the repository is marked as failing the build.

[joehandzik]

Why is mega in this line twice?

[mjtrangoni]

fixed

[roclark]

@mjtrangoni now that @joehandzik fixed the issues raised by megacheck and merged them with master, do you mind rebasing against the latest master commit again? I will pull this in once rebased and all of the checks are passing!

Edit: Nevermind - I remembered I can manually retrigger the build, so you are good to go!