Add missing ldlm pool stats #79
Conversation
sources/procfs.go
Outdated
| {"pool/granted", "locks_granted_total", "Number of granted locks", s.counterMetric}, | ||
| {"pool/grant_plan", "lock_grant_plan", "Number of planned lock grants for time period", s.gaugeMetric}, |
There was a problem hiding this comment.
Do we know what the time period is? We should clarify that...otherwise we may not understand the metric.
There was a problem hiding this comment.
I will do some more digging, but I couldn't find anything immediately obvious.
There was a problem hiding this comment.
From issue #67:
lustre/ldlm/ldlm_pool.c: lprocfs_counter_init(pl->pl_stats, LDLM_POOL_GRANT_PLAN_STAT,
lustre/ldlm/ldlm_pool.c- LPROCFS_CNTR_AVGMINMAX | LPROCFS_CNTR_STDDEV,
lustre/ldlm/ldlm_pool.c- "grant_plan", "locks/s");
So, it's per second. I would change the help text to indicate that. Otherwise, everything else looked good.
|
Latest: I removed the |
|
Aren't the Regarding |
roclark
force-pushed
the
wip-fix-issue-67
branch
2 times, most recently
from
78c8f3b to
9d77869
Compare
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
|
@knweiss good catch on |
sources/procfs.go
Outdated
| {"pool/recalc_freed", "recalc_freed_total", "Number of locks that have been freed", s.counterMetric}, | ||
| {"pool/recalc_timing", "recalc_timing_seconds_total", "Number of seconds spent locked", s.counterMetric}, | ||
| {"pool/shrink_freed", "shrink_freed_total", "Number of shrinks that have been freed", s.counterMetric}, | ||
| {"pool/shrink_request", "shrink_requests", "Number of shrinks that have been requested", s.gaugeMetric}, |
There was a problem hiding this comment.
Good catch. This should probably be changed to a counter as well then.
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
Fixes #67
Signed-Off-By: Robert Clark robert.d.clark@hpe.com