Tweak metric naming for file_* and *_now values #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roclark
reviewed
May 17, 2017
There was a problem hiding this comment.
Just some of my thoughts, feel free to take or leave them as you see fit. As always, great work Mr. @joehandzik !
sources/procfs.go
Outdated
| {"filesfree", "files_free_now", "The number of inodes (objects) available", s.gaugeMetric}, | ||
| {"filestotal", "file_capacity", "The maximum number of inodes (objects) the filesystem can hold", s.gaugeMetric}, | ||
| {"degraded", "degraded", "Binary indicator as to whether or not the pool is degraded - 0 for not degraded, 1 for degraded", s.gaugeMetric}, | ||
| {"filesfree", "inode_free", "The number of inodes (objects) available", s.gaugeMetric}, |
There was a problem hiding this comment.
This might be an unpopular opinion, but I prefer inodes_free here. I interpret inode_free to mean whether a particular inode is free or not (which doesn't make sense), but that's just me.
sources/procfs.go
Outdated
| {"filestotal", "file_capacity", "The maximum number of inodes (objects) the filesystem can hold", s.gaugeMetric}, | ||
| {"degraded", "degraded", "Binary indicator as to whether or not the pool is degraded - 0 for not degraded, 1 for degraded", s.gaugeMetric}, | ||
| {"filesfree", "inode_free", "The number of inodes (objects) available", s.gaugeMetric}, | ||
| {"filestotal", "inode_capacity", "The maximum number of inodes (objects) the filesystem can hold", s.gaugeMetric}, |
There was a problem hiding this comment.
Same as above, inodes_capacity is a little more straightforward in my mind.
sources/procfs.go
Outdated
| {"filestotal", "file_capacity", "The maximum number of inodes (objects) the filesystem can hold", s.gaugeMetric}, | ||
| {"kbytesavail", "kilobytes_available_now", "Number of kilobytes readily available in the pool", s.gaugeMetric}, | ||
| {"kbytesfree", "kilobytes_free_now", "Number of kilobytes allocated to the pool", s.gaugeMetric}, | ||
| {"filesfree", "inode_free", "The number of inodes (objects) available", s.gaugeMetric}, |
sources/procfs.go
Outdated
| {"kbytesavail", "kilobytes_available_now", "Number of kilobytes readily available in the pool", s.gaugeMetric}, | ||
| {"kbytesfree", "kilobytes_free_now", "Number of kilobytes allocated to the pool", s.gaugeMetric}, | ||
| {"filesfree", "inode_free", "The number of inodes (objects) available", s.gaugeMetric}, | ||
| {"filestotal", "inode_capacity", "The maximum number of inodes (objects) the filesystem can hold", s.gaugeMetric}, |
sources/procfs.go
Outdated
| {"filestotal", "file_capacity", "The maximum number of inodes (objects) the filesystem can hold", s.gaugeMetric}, | ||
| {"kbytesavail", "kilobytes_available_now", "Number of kilobytes readily available in the pool", s.gaugeMetric}, | ||
| {"kbytesfree", "kilobytes_free_now", "Number of kilobytes allocated to the pool", s.gaugeMetric}, | ||
| {"filesfree", "inode_free", "The number of inodes (objects) available", s.gaugeMetric}, |
sources/procfs.go
Outdated
| {"kbytesavail", "kilobytes_available_now", "Number of kilobytes readily available in the pool", s.gaugeMetric}, | ||
| {"kbytesfree", "kilobytes_free_now", "Number of kilobytes allocated to the pool", s.gaugeMetric}, | ||
| {"filesfree", "inode_free", "The number of inodes (objects) available", s.gaugeMetric}, | ||
| {"filestotal", "inode_capacity", "The maximum number of inodes (objects) the filesystem can hold", s.gaugeMetric}, |
joehandzik
force-pushed
the
wip-fix-issue-72
branch
2 times, most recently
from
fe93a7e to
9b001cb
Compare
|
I think I prefer |
roclark
approved these changes
May 17, 2017
Addresses issue #72 by removing plurality, moving from file to inode for naming purposes, and removing all cases of appending _now to metrics to denote instantaneous values. Signed-Off-By: Joe Handzik <joseph.t.handzik@hpe.com>
joehandzik
force-pushed
the
wip-fix-issue-72
branch
from
9b001cb to
c61aa46
Compare
|
Ok, done, but with a slight change in plans. Instead of 'inodes_available', I used 'inodes_maximum' after talking with @roclark. We felt that inodes_available and inodes_free were too similar (and based on the help text, 'inodes_available' aren't really all available at all, hence the existence of inodes_free). Long-winded, but hopefully that rationale makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #72 by removing plurality, moving from file to inode for naming purposes, and removing all cases of appending _now to metrics to denote instantaneous values.
Signed-Off-By: Joe Handzik joseph.t.handzik@hpe.com