-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing md_stats #66
Conversation
Fixes issue #62. Signed-Off-By: Joe Handzik <joseph.t.handzik@hpe.com>
@knweiss, would appreciate it if you took a look too, just to make sure all the metrics you are missing are accounted for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the help text constants (mknodHelp
, linkHelp
, unlinkHelp
...) should actually be declared up above with the desired help text. They are used further below to connect the variable with the intended parsing scheme. Also, these variables should be added to the map on lines 452-483 with an index value of 0
as these all will use the first numerical value on the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scratch my last review - I didn't realize these were already added. Looks good to me now!
Yes, I think the
|
Fixes issue #62.
Signed-Off-By: Joe Handzik joseph.t.handzik@hpe.com