Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip jobstats metric if they don't exist #60

Merged
merged 1 commit into from
May 12, 2017

Conversation

roclark
Copy link
Contributor

@roclark roclark commented May 12, 2017

In case a particular jobstats metric isn't located on a node, skip over
it instead of trying to parse a value, yielding unexpected results.

Signed-Off-By: Robert Clark robert.d.clark@hpe.com

In case a particular jobstats metric isn't located on a node, skip over
it instead of trying to parse a value, yielding unexpected results.

Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
@roclark roclark requested a review from joehandzik May 12, 2017 20:39
@joehandzik
Copy link
Contributor

Hmm, out of curiosity, what were the unexpected values?

@joehandzik joehandzik merged commit d1d3b1b into master May 12, 2017
@roclark
Copy link
Contributor Author

roclark commented May 12, 2017

@joehandzik it would default to parsing the job_id for the specified block. So if, for some reason, one job had write_bytes but another job didn't, you would get expected results for the first, but they would be compared against job_id for the other which would obviously be confusing.

@roclark roclark deleted the wip-skip-nonexistant-metrics branch May 12, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants