Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse metrics from stats file #6

Merged
merged 2 commits into from
Apr 3, 2017

Conversation

roclark
Copy link
Contributor

@roclark roclark commented Mar 21, 2017

No description provided.

@roclark
Copy link
Contributor Author

roclark commented Mar 21, 2017

Not completely finished yet, but I wanted to see if you had any feedback/suggestions while I am in the middle of the implementation. So far, I am able to get 8 new metrics (all that I am planning on including from this file at the moment), but I have the following items left to complete:

  • Handle magic-numbers on lines 168-180
  • Add help text for all metrics within the stats file

@roclark
Copy link
Contributor Author

roclark commented Mar 29, 2017

FYI: I added a commit which includes help text for the new metrics, but I haven't been able to fully test and format it, so this is still a WIP. If, however, the tests pass and it doesn't need to be formatted further, this will be the final update. I will update once I get more info.

@roclark roclark force-pushed the parse-stats-file branch 2 times, most recently from bffea53 to 7b15042 Compare March 31, 2017 14:03
@roclark
Copy link
Contributor Author

roclark commented Mar 31, 2017

All formatted and tested and looks good to me! Ready to merge whenever you are.

Robert Clark added 2 commits April 3, 2017 09:39
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
@roclark roclark force-pushed the parse-stats-file branch from 7b15042 to 41f29aa Compare April 3, 2017 14:39
@roclark
Copy link
Contributor Author

roclark commented Apr 3, 2017

Putting this on hold again. I believe I found a way to retrieve the same metrics for the MGS/MDS nodes. I will play around with that and see if it is feasible or not and let you know what I find.

@roclark
Copy link
Contributor Author

roclark commented Apr 3, 2017

Nevermind, looks like the stats files on the MGS/MDS nodes does not contain the same metrics. Good to go once again.

@joehandzik
Copy link
Contributor

LGTM

@joehandzik joehandzik merged commit b5fd943 into HewlettPackard:master Apr 3, 2017
@roclark roclark deleted the parse-stats-file branch April 5, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants