Specify Prometheus metric type for all metrics #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calling metric function can now be set to easily specify which metric type should be used for Prometheus. Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
|
@joehandzik we can either go through the types now or create another PR once this is done (similar to how we did the metric renaming), the choice is yours. |
|
We can fix it as part of my current PR for renaming. This looks good, I'll rebase these changes into my branch later today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calling metric function can now be set to easily specify which
metric type should be used for Prometheus.
Signed-Off-By: Robert Clark robert.d.clark@hpe.com