Clean up golint warnings #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roclark Pull this in if you agree to the changes (nothing seemed crazy to me). You can run yourself if you want: https://github.com/golang/lint FYI, these changes are all in the interest of cleaning up our scores here: https://goreportcard.com/report/github.com/HewlettPackard/lustre_exporter |
roclark
suggested changes
May 1, 2017
sources/source.go
Outdated
| @@ -17,10 +17,13 @@ import ( | |||
| "github.com/prometheus/client_golang/prometheus" | |||
| ) | |||
|
|
|||
| //Namespace defineds the namespace shared by all Lustre metrics. | |||
Signed-Off-By: Joe Handzik <joseph.t.handzik@hpe.com>
joehandzik
force-pushed
the
wip-fix-golint-warnings
branch
from
aebaa7d to
15c6c2e
Compare
|
@roclark Good call, don't wanna inject another problem. All fixed now, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-Off-By: Joe Handzik joseph.t.handzik@hpe.com