Update Lustre test data and fix metrics for 2.10.1 #130
Conversation
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
Signed-Off-By: Robert Clark <robert.d.clark@hpe.com>
Signed-Off-By: Joe Handzik <joseph.t.handzik@hpe.com>
| @@ -16,7 +16,7 @@ GOPATH := $(firstword $(subst :, ,$(shell $(GO) env GOPATH))) | |||
| PROMU ?= $(GOPATH)/bin/promu | |||
| GOLINTER ?= $(GOPATH)/bin/gometalinter | |||
| #aligncheck and gosimple took unfortunately too long at travisCI | |||
| GOLINTER_OPT ?= --vendor --deadline 6m --cyclo-over=20 --disable=aligncheck --disable=gosimple | |||
There was a problem hiding this comment.
Just for my curiosity, what was the issue with gotype?
There was a problem hiding this comment.
gotype was catching a false positive in a variable not being defined in the sources package, which led to roughly two hours of serious golang soul searching. The code works correctly, it is a false positive as far as I can tell.
lustre_exporter_test.go
Outdated
| {"lustre_job_write_bytes_total", "The total number of bytes that have been written.", counter, []labelPair{{"component", "ost"}, {"jobid", "23"}, {"target", "lustrefs-OST0000"}}, 1.55500642304e+11, false}, | ||
| {"lustre_job_write_bytes_total", "The total number of bytes that have been written.", counter, []labelPair{{"component", "ost"}, {"jobid", "24"}, {"target", "lustrefs-OST0000"}}, 2.15147593728e+11, false}, | ||
| {"lustre_job_write_bytes_total", "The total number of bytes that have been written.", counter, []labelPair{{"component", "ost"}, {"jobid", "25"}, {"target", "lustrefs-OST0000"}}, 2.40823762944e+11, false}, | ||
| {"lustre_job_write_bytes_total", "The total number of bytes that have been written.", counter, []labelPair{{"component", "ost"}, {"jobid", "26"}, { |
There was a problem hiding this comment.
Teeeeechnically I think this should be in a different section (//Health Metrics), but I'm definitely not offended by this.
There was a problem hiding this comment.
This was tagged on the wrong line somehow... but I'm referring to line 1647 which I added as a standalone comment below. This can be disregarded!
There was a problem hiding this comment.
Ignoring like a champ
lustre_exporter_test.go
Outdated
| @@ -1631,7 +1644,7 @@ func TestCollector(t *testing.T) { | |||
| {"lustre_rpcs_in_flight", "Current number of RPCs that are processing during the snapshot.", gauge, []labelPair{{"component", "client"}, {"operation", "write"}, {"size", "9"}, {"target", "lustrefs-OST0000-osc-ffff88105db50000"}, {"type", "osc"}}, 272560, false}, | |||
|
|
|||
| // Generic Metrics | |||
| {"lustre_health_check", "Current health status for the indicated instance: 1 refers to 'healthy', 0 refers to 'unhealthy'", gauge, []labelPair{{"component", "generic"}, {"target", "lustre"}}, 1, false}, | |||
| {"lustre_health_check", "Current health status for the indicated instance: 1 refers to 'healthy', 0 refers to 'unhealthy'", gauge, []labelPair{{"component", "health"}, {"target", "lustre"}}, 1, false}, | |||
There was a problem hiding this comment.
Teeeeechnically I think this should be in a different section (//Health Metrics), but I'm definitely not offended by this.
There was a problem hiding this comment.
I'll move it! Thanks for catching.
joehandzik
force-pushed
the
wip-update-lustre-test-data
branch
2 times, most recently
from
a52f15e to
fc57003
Compare
|
@roclark Fixed the test line and added an update to the README for the new health flag. Everything should be good to go! |
Multiple parts here:
The change set breaks at least ten or so metrics across the MGS, MDS, and generic metric categories. We view this as acceptable, since we have tagged 1.x versions that should work correctly with that data.