forked from moos-ivp/moos-ivp
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add myfile #5
Draft
HeroCC
wants to merge
86
commits into
main
Choose a base branch
from
cc/test-main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add myfile #5
+362
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly taken from my extend tree
Remove the `--release` flag. This will make binaries a bit larger and slower, but is generally how most people build moos anyway. This should also keep us from rebuilding the same libraries multiple times.
Split images are making tings difficult to debug. Let's get things working, and move back to parallelization if needed.
This reverts commit 1918951. It takes too long. https://docs.docker.com/build/ci/github-actions/multi-platform/#distribute-build-across-multiple-runners is better, but not great -- too hacky, and relies on undocumented functionality. I'll make something better.
The gui layer is not respecting the already-built minrobot libraries. Probably because we install a bunch of new libraries. Since we're not using the cache anyway, split the layers explicitly.
Utilize maximum caching, since this changes rarely
Simplify things more (until arch native runners come around)
Maybe this is cache busting?
May be slower, but is more understandable and less complex
Doesn't actually save us much time. Reduce some complexity.
SOURCE_DATE_EPOCH is used by GCC and other utilities to attempt to generate reproducable artifacts.
Want to confirm our $FROM is being honored
Silly me :)
Not sure if Github will accept matrix builds like this
We don't necessarily publish
Run in the fork's namespace, not the upstream.
We only publish images on `main` and on forks.
Symlinked to `.gitignore`. I've been using this pattern in my extend tree for successfully to prevent undesired artifacts from making their way into the docker image.
Much of the `baserobot` binaries are rebuilt after we install new libraries, so we're not benefitting from the shared cache. This also simplifies the build process, and doesn't push (only builds) intermediate images unless we plan to publish them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.