Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing profile instances directly to MassModel and LightModel #36

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

aymgal
Copy link
Member

@aymgal aymgal commented Jul 30, 2024

Addresses #33

@aymgal aymgal merged commit b605e7f into main Jul 30, 2024
1 check passed
@aymgal aymgal deleted the pr-massmodel-init-refac branch July 30, 2024 23:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10171331815

Details

  • 75 of 105 (71.43%) changed or added relevant lines in 7 files are covered.
  • 18 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.6%) to 24.034%

Changes Missing Coverage Covered Lines Changed/Added Lines %
herculens/LightModel/light_model.py 4 5 80.0%
herculens/MassModel/mass_model.py 4 5 80.0%
herculens/MassModel/mass_model_base.py 22 34 64.71%
herculens/LightModel/light_model_base.py 24 40 60.0%
Files with Coverage Reduction New Missed Lines %
herculens/MassModel/Profiles/epl.py 5 52.81%
herculens/Util/jax_util.py 13 42.86%
Totals Coverage Status
Change from base Build 10162148583: 0.6%
Covered Lines: 1573
Relevant Lines: 6545

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants