Skip to content

Commit

Permalink
Nagging 'ties.method' warnings now happens every 10:th call [#142]
Browse files Browse the repository at this point in the history
  • Loading branch information
HenrikBengtsson committed Jan 3, 2025
1 parent 74e3355 commit 7bc60e4
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 9 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Package: matrixStats
Version: 1.4.1-9008
Version: 1.4.1-9009
Depends:
R (>= 3.4.0)
Suggests:
Expand Down
16 changes: 11 additions & 5 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,20 @@
= NA` to a warning has been removed; `useNames = NA` is now always
an error.

* Calling `colRanks()` and `rowRanks()` without explicitly specifying
argument `ties.method` is deprecated since version 1.3.0
[2024-04-10]. If not explicitly specified, a deprecation warning is
now produced every 10:th call not specifying the `ties.method`
argument.


# Version 1.4.1 [2024-09-06]

## Bug Fixes

* Fix a potential `runtime error: null pointer passed as argument 1,
which is declared to never be null` bug introduced in v1.4.0 that
was detected by the UndefinedBehaviorSanitizer (UBSan) running on CRAN.
* Fix a `runtime error: null pointer passed as argument 1, which is
declared to never be null` bug introduced in v1.4.0 that was
detected by the UndefinedBehaviorSanitizer (UBSan) running on CRAN.


# Version 1.4.0 [2024-09-03]
Expand All @@ -43,8 +49,8 @@
## Deprecated and Defunct

* Calling `colRanks()` and `rowRanks()` without explicitly specifying
argument `ties.method` is deprecated since version 1.3.0. If not
explicitly specified, a deprecation warning is now produced every
argument `ties.method` is deprecated since version 1.3.0 [2024-04-10].
If not explicitly specified, a deprecation warning is now produced every
25:th call not specifying the `ties.method` argument.


Expand Down
4 changes: 2 additions & 2 deletions R/options.R
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
#' \describe{
#' \item{\option{matrixStats.ties.method.freq}:}{(numeric)
#' Controls how often the above validation is checked.
#' (Default: \code{25} - every 25:th call starting with the first)}
#' (Default: \code{10} - every 10:th call starting with the first)}
#' }
#'
#' @section Environment variables that set R options:
Expand Down Expand Up @@ -203,5 +203,5 @@ update_package_options <- function() {

update_package_option("matrixStats.ties.method.missing", default = if (getRversion() >= "4.4.0") "deprecated" else "ignore", choices = c("deprecated", "defunct", "ignore"))

update_package_option("matrixStats.ties.method.freq", mode = "numeric", default = "25")
update_package_option("matrixStats.ties.method.freq", mode = "numeric", default = "10")
}
2 changes: 1 addition & 1 deletion man/matrixStats.options.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7bc60e4

Please sign in to comment.