BUG FIX: col-/rowTabulates() reported on class rather than storage ty…

…pe of the input data [#275]
HenrikBengtsson · Jan 6, 2025 · 772e61c · 772e61c
1 parent bed6981
commit 772e61c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,5 +1,5 @@
 Package: matrixStats
-Version: 1.4.1-9012
+Version: 1.4.1-9013
 Depends:
   R (>= 3.4.0)
 Suggests:

diff --git a/NEWS.md b/NEWS.md
@@ -17,7 +17,13 @@
    [2024-04-10]. If not explicitly specified, a deprecation warning is
    now produced every 10:th call not specifying the `ties.method`
    argument.
-
+
+## Bug Fixes
+
+ * The error message of `colTabulates()` and `rowTabulates()`
+   asserting that double values are passed, reported on the class of
+   the input data, not the storage type.
+
 
 # Version 1.4.1 [2024-09-06]
 

diff --git a/R/rowTabulates.R b/R/rowTabulates.R
@@ -37,7 +37,7 @@ rowTabulates <- function(x, rows = NULL, cols = NULL, values = NULL, ..., useNam
   } else if (is.logical(x)) {
   } else if (is.raw(x)) {
   } else {
-    stop(sprintf("Argument '%s' is not integer, logical, or raw: %s", "x", class(x)[1]))
+    stop(sprintf("Argument '%s' is not integer, logical, or raw: %s", "x", storage.mode(x)))
   }
 
   # Apply subset
@@ -102,7 +102,7 @@ colTabulates <- function(x, rows = NULL, cols = NULL, values = NULL, ..., useNam
   } else if (is.logical(x)) {
   } else if (is.raw(x)) {
   } else {
-    stop(sprintf("Argument '%s' is not integer, logical, or raw: %s", "x", class(x)[1]))
+    stop(sprintf("Argument '%s' is not integer, logical, or raw: %s", "x", storage.mode(x)))
   }
 
   # Apply subset