Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(tooltip): fix flaky GH action - $onConnect #885

Merged
merged 1 commit into from
Jul 22, 2021
Merged

test(tooltip): fix flaky GH action - $onConnect #885

merged 1 commit into from
Jul 22, 2021

Conversation

100stacks
Copy link
Member

Description

  • Fix flaky GH Action for <hx-tooltip> $onConnect test

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2122

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@100stacks 100stacks added this to the HelixUI-v2.4.0 milestone Jul 21, 2021
@netlify
Copy link

netlify bot commented Jul 21, 2021 •
edited
Loading

✔️ Deploy Preview for helix-ui ready!

🔨 Explore the source changes: efae8e7

🔍 Inspect the deploy log: https://app.netlify.com/sites/helix-ui/deploys/60f88898cbf6460007ffe448

😎 Browse the preview: https://deploy-preview-885--helix-ui.netlify.app

@100stacks 100stacks force-pushed the surf-2122-tooltip-test branch from aa94fb1 to efae8e7 Compare July 21, 2021 20:50
badejayayesubabu
badejayayesubabu approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

lalithkarikelli
lalithkarikelli approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@100stacks 100stacks merged commit 207aadd into master Jul 22, 2021
@100stacks 100stacks deleted the surf-2122-tooltip-test branch July 22, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

@badejayayesubabu badejayayesubabu badejayayesubabu approved these changes

Assignees
No one assigned
Labels
📋 Testing ⚙️ Pipeline
Projects
None yet
Milestone
HelixUI-v2.4.0-rc.0
Development

Successfully merging this pull request may close these issues.
3 participants
@100stacks @lalithkarikelli @badejayayesubabu