Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(switch): implement and document variables and attributes #882

Merged
merged 4 commits into from
Jul 26, 2021
Merged

docs(switch): implement and document variables and attributes #882

merged 4 commits into from
Jul 26, 2021

Conversation

lalithkarikelli
Copy link
Contributor

@lalithkarikelli lalithkarikelli commented Jun 10, 2021 •
edited
Loading

Description

<hx-switch> : Implement and document variables and attributes

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF 2128

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Jun 10, 2021 •
edited
Loading

✔️ Deploy Preview for helix-ui ready!

🔨 Explore the source changes: ac7c33c

🔍 Inspect the deploy log: https://app.netlify.com/sites/helix-ui/deploys/60ff349705bd070008e84d28

😎 Browse the preview: https://deploy-preview-882--helix-ui.netlify.app

100stacks
100stacks requested changes Jul 21, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use v2.0 color variables.

@lalithkarikelli lalithkarikelli marked this pull request as ready for review July 22, 2021 14:15
100stacks
100stacks approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally we aren't referencing the $design-tokens directly. This should still work fine.

Good job! Dev LGTM

badejayayesubabu
badejayayesubabu approved these changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@100stacks 100stacks added this to the HelixUI-v2.4.0 milestone Jul 26, 2021
@100stacks 100stacks changed the title docs(hx-switch): implement and document variables and attributes docs(switch): implement and document variables and attributes Jul 26, 2021
@100stacks 100stacks merged commit 585dd6e into HelixDesignSystem:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100stacks 100stacks 100stacks approved these changes

@badejayayesubabu badejayayesubabu badejayayesubabu approved these changes

Assignees
No one assigned
Labels
CSS 📝 Documentation
Projects
None yet
Milestone
HelixUI-v2.4.0-rc.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lalithkarikelli @100stacks @badejayayesubabu