Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(layout): implement and document variables and attributes #873

Merged
merged 2 commits into from
Jul 27, 2021
Merged

refactor(layout): implement and document variables and attributes #873

merged 2 commits into from
Jul 27, 2021

Conversation

lalithkarikelli
Copy link
Contributor

@lalithkarikelli lalithkarikelli commented May 6, 2021 •
edited
Loading

Description

<hx-layout> : Implement and document variables and attributes

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF 2110

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented May 6, 2021 •
edited
Loading

✔️ Deploy Preview for helix-ui ready!

🔨 Explore the source changes: bc7ee35

🔍 Inspect the deploy log: https://app.netlify.com/sites/helix-ui/deploys/60ff8948df4a61000857f1cd

😎 Browse the preview: https://deploy-preview-873--helix-ui.netlify.app

@lalithkarikelli lalithkarikelli marked this pull request as ready for review May 7, 2021 06:42
@100stacks 100stacks added this to the HelixUI-v2.4.0 milestone May 28, 2021
100stacks
100stacks requested changes Jul 21, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use v2.0 color variables.

100stacks
100stacks approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks changed the title refactor(hx-layout): implement and document variables and attributes refactor(layout): implement and document variables and attributes Jul 27, 2021
@100stacks 100stacks merged commit 84a6688 into HelixDesignSystem:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100stacks 100stacks 100stacks approved these changes

@badejayayesubabu badejayayesubabu Awaiting requested review from badejayayesubabu

Assignees
No one assigned
Labels
CSS 📝 Documentation
Projects
None yet
Milestone
HelixUI-v2.4.0-rc.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lalithkarikelli @100stacks