refactor(breadcrumb): implement design tokens specs #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for helix-ui ready! Built with commit 35d8fe1 |
badejayayesubabu
force-pushed
the
SURF-2200
branch
from
98ae29a to
1a53c8b
Compare
badejayayesubabu
force-pushed
the
SURF-2200
branch
2 times, most recently
from
0dda9f1 to
107900b
Compare
100stacks
requested changes
Apr 19, 2021
| color: $gray-800; | ||
| color: $rax-component-breadcrumb-current-color; |
There was a problem hiding this comment.
Let's use this pattern:
color: $rax-component-breadcrumb-current-color;
color: var(--hxBreadcrumb-last-type-color, $rax-component-breadcrumb-current-color);There was a problem hiding this comment.
Changes have been done, please review.
| color: $gray-600; | ||
| color: $rax-component-breadcrumb-separator-color; |
There was a problem hiding this comment.
Let's use the same pattern above.
There was a problem hiding this comment.
Changes have been done, please review.
| @@ -3,25 +3,28 @@ | |||
| align-content: center; | |||
| align-items: center; | |||
| color: $blue-500; | |||
| color: $rax-component-breadcrumb-base-color; | |||
There was a problem hiding this comment.
Let's use the IE11 fallback pattern below.
There was a problem hiding this comment.
Changes have been done, please review.
| margin-right: 0.5rem; | ||
| color: $gray-600; | ||
| color: $rax-component-breadcrumb-separator-color; | ||
| font-size: 0.5rem;//there is no token for font size |
badejayayesubabu
force-pushed
the
SURF-2200
branch
from
107900b to
8f7de72
Compare
badejayayesubabu
force-pushed
the
SURF-2200
branch
from
8c736da to
35d8fe1
Compare
100stacks
added
Design Tokens
100stacks
changed the title
100stacks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<breadcrumb>: implement design tokensWhat are the relevant story cards/tickets? Any additional PRs or other references?
Jira: SURF-2200
Before you request a review for this PR:
yarn testto ensure all tests passed?