Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(invalid): update default color #844

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

100stacks
Copy link
Member

Description

Update the default Invalid and Error state color to v2.0 specifications.

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2191

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@100stacks 100stacks added CSS 🆕 New Component Specs Updated Component Specifications labels Mar 10, 2021
@100stacks 100stacks added this to the HelixUI-v2.2.0 milestone Mar 10, 2021
@netlify
Copy link

netlify bot commented Mar 10, 2021

Deploy preview for helix-ui ready!

Built with commit d7c3414

https://deploy-preview-844--helix-ui.netlify.app

* fix alert for IE11
* fix badge for IE11
@100stacks 100stacks force-pushed the surf-2191-invalid-states branch from e304c33 to d7c3414 Compare March 10, 2021 01:05
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@100stacks 100stacks merged commit 26daa79 into master Mar 10, 2021
@100stacks 100stacks deleted the surf-2191-invalid-states branch March 25, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS 🆕 New Component Specs Updated Component Specifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants