Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(choice-tile): implement new slim option #837

Merged
merged 1 commit into from
Mar 11, 2021
Merged

feat(choice-tile): implement new slim option #837

merged 1 commit into from
Mar 11, 2021

Conversation

badejayayesubabu
Copy link
Collaborator

@badejayayesubabu badejayayesubabu commented Feb 24, 2021 •
edited
Loading

Description

<hx-choice-tile>: Added the new slim option choice tile

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2154

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Feb 24, 2021 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit e09e8c5

https://deploy-preview-837--helix-ui.netlify.app

@100stacks 100stacks added the 🆕 New Component Specs Updated Component Specifications label Feb 24, 2021
@100stacks 100stacks added this to the HelixUI-v2.x milestone Feb 24, 2021
100stacks
100stacks requested changes Feb 25, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BY00565233, please check and verify these updates work in IE11 and Legacy Edge along with Firefox, Safari, and Chrome.

We want the default styles and functionality to work in IE11 and Legacy Edge.

@100stacks 100stacks added the PR: Comments Provided PR: Comments Provided label Feb 25, 2021
@100stacks 100stacks removed the PR: Comments Provided PR: Comments Provided label Mar 3, 2021
100stacks
100stacks requested changes Mar 3, 2021
View reviewed changes
src/scss/components/choice-tile/_index.scss Outdated
Comment on lines 60 to 61
height: 64px;
width: 221px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use rem units. Only go to X.XX rem for values.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, Please review

src/scss/components/choice-tile/_index.scss
@@ -18,13 +18,15 @@ hx-tile {
font-size: 1rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify Choice Tile component next specs.

Also remove border-radius (Line 10).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, Please review

src/scss/components/choice-tile/_index.scss Outdated
@@ -18,13 +18,15 @@ hx-tile {
font-size: 1rem;
font-weight: 700;
margin-bottom: 0;
color: $gray-700;
color: var(--hxChoiceTile-header-color, $gray-700);
line-height: 24px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert to rem units.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, Please review

@100stacks 100stacks added the PR: Comments Provided PR: Comments Provided label Mar 3, 2021
@badejayayesubabu badejayayesubabu force-pushed the SURF-2154 branch 2 times, most recently from b177607 to fc3a286 Compare March 3, 2021 10:09
@100stacks 100stacks modified the milestones: HelixUI-v2.x, HelixUI-v2.2.0 Mar 3, 2021
@100stacks 100stacks marked this pull request as ready for review March 3, 2021 20:57
lalithkarikelli
lalithkarikelli approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@badejayayesubabu badejayayesubabu force-pushed the SURF-2154 branch 4 times, most recently from d06b8a4 to 0d44fd9 Compare March 10, 2021 18:05
@100stacks 100stacks changed the title refactor(choice-tile): added new slim option choice tile feat(choice-tile): implement new slim option Mar 11, 2021
100stacks
100stacks approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks merged commit 2b7c6b8 into HelixDesignSystem:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100stacks 100stacks 100stacks approved these changes

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

Assignees
No one assigned
Labels
🆕 New Component Specs Updated Component Specifications
Projects
None yet
Milestone
HelixUI-v2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@badejayayesubabu @100stacks @lalithkarikelli