Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(various): update component specs #831

Merged
merged 1 commit into from
Feb 18, 2021
Merged

feat(various): update component specs #831

merged 1 commit into from
Feb 18, 2021

Conversation

100stacks
Copy link
Member

@100stacks 100stacks commented Feb 11, 2021 •
edited
Loading

Description

  • remove button 2px border-radius
  • update checkbox specs
  • update radio specs
  • update popover specs

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira:

  • SURF-2171
  • SURF-2173
  • SURF-2174

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@100stacks 100stacks added the 🆕 New Component Specs Updated Component Specifications label Feb 11, 2021
@100stacks 100stacks added this to the HelixUI-v2.0.1 milestone Feb 11, 2021
@netlify
Copy link

netlify bot commented Feb 11, 2021 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 03dbc76

https://deploy-preview-831--helix-ui.netlify.app

@100stacks
feat(button): update component specs
03dbc76 
* remove button 2px `border-radius`
* update checkbox specs
* update radio specs
* update popover specs
@100stacks 100stacks force-pushed the surf-2171-button-update-specs branch from a44dfc5 to 03dbc76 Compare February 18, 2021 00:29
@100stacks 100stacks changed the title feat(button): update component specs feat(various): update component specs Feb 18, 2021
lalithkarikelli
lalithkarikelli approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

badejayayesubabu
badejayayesubabu approved these changes Feb 18, 2021
View reviewed changes
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

100stacks
100stacks commented Feb 18, 2021
View reviewed changes
Copy link
Member Author

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielmdesigns, Lane approved this PR with these changes for the team.

@100stacks 100stacks merged commit e760a17 into master Feb 18, 2021
@100stacks 100stacks deleted the surf-2171-button-update-specs branch March 4, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

@badejayayesubabu badejayayesubabu badejayayesubabu approved these changes

@danielmdesigns danielmdesigns Awaiting requested review from danielmdesigns

Assignees
No one assigned
Labels
🆕 New Component Specs Updated Component Specifications
Projects
None yet
Milestone
HelixUI-v2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@100stacks @lalithkarikelli @badejayayesubabu