Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(file): implement and document attrs and vars #828

Merged
merged 1 commit into from
Mar 3, 2021
Merged

docs(file): implement and document attrs and vars #828

merged 1 commit into from
Mar 3, 2021

Conversation

badejayayesubabu
Copy link
Collaborator

@badejayayesubabu badejayayesubabu commented Feb 8, 2021 •
edited
Loading

Description

<hx-file> : implement and document attributes and variables

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2107

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Feb 8, 2021 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 76e97c6

https://deploy-preview-828--helix-ui.netlify.app

100stacks
100stacks requested changes Feb 24, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BY00565233, please check and verify these updates work in IE11 and Legacy Edge along with Firefox, Safari, and Chrome.

@100stacks 100stacks added this to the HelixUI-v2.x milestone Feb 24, 2021
@badejayayesubabu
Copy link
Collaborator Author

@BY00565233, please check and verify these updates work in IE11 and Legacy Edge along with Firefox, Safari, and Chrome.

@100stacks I verified and updated the code to work in all 5 browsers . please review

100stacks
100stacks requested changes Mar 3, 2021
View reviewed changes
src/scss/components/file/_hx-file-tile.scss Outdated
Comment on lines 18 to 19
border-color: $red-status-900;
border-color: var(--hxFile-hxFileTile-invalid-border-color, $red-status-900);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change [invalid] status colors to $red-status-500.

@100stacks 100stacks added Need: Dev LGTM PR: Comments Provided PR: Comments Provided and removed PR: Comments Provided PR: Comments Provided labels Mar 3, 2021
@100stacks 100stacks modified the milestones: HelixUI-v2.x, HelixUI-v2.2.0 Mar 3, 2021
@100stacks 100stacks marked this pull request as ready for review March 3, 2021 02:58
lalithkarikelli
lalithkarikelli approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

100stacks
100stacks approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks changed the title docs(hx-file): implement and document attributes and variables docs(file): implement and document attrs and vars Mar 3, 2021
@100stacks 100stacks merged commit 6e878cb into HelixDesignSystem:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100stacks 100stacks 100stacks approved these changes

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

Assignees
No one assigned
Labels
CSS 📝 Documentation
Projects
None yet
Milestone
HelixUI-v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@badejayayesubabu @100stacks @lalithkarikelli @BadeJaya