docs(hx-menu): implement and document vars and attrs #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for helix-ui ready! Built with commit 2cee3b1 |
badejayayesubabu
force-pushed
the
SURF-2113
branch
from
a7001a9 to
1b62a1f
Compare
100stacks
requested changes
Feb 2, 2021
src/scss/components/menu/_index.scss
Outdated
| @@ -44,7 +44,7 @@ hx-menuitem { | |||
| background-color: transparent; | |||
| border-radius: 2px; | |||
| border: none; | |||
| color: $cyan-900; | |||
| color: var(--hxMenu-hxMenuitem-color, $cyan-900); | |||
There was a problem hiding this comment.
Please update color variable to Color Palette 2.0 specs.
There was a problem hiding this comment.
Changes have been done, Please review
src/scss/components/menu/_index.scss
Outdated
| @@ -56,13 +56,13 @@ hx-menuitem { | |||
| &:hover { | |||
| background-color: transparent; | |||
| border-color: transparent; | |||
| color: $cyan-500; | |||
| color: var(--hxMenu-hxMenuitem-hover-color, $cyan-500); | |||
There was a problem hiding this comment.
Please update color variable to Color Palette 2.0 specs.
There was a problem hiding this comment.
Changes have been done, Please review
src/scss/components/menu/_index.scss
Outdated
| } | ||
|
|
||
| &:active { | ||
| background-color: transparent; | ||
| border-color: transparent; | ||
| color: $cyan-700; | ||
| color: var(--hxMenu-hxMenuitem-active-color, $cyan-700); |
There was a problem hiding this comment.
Please update color variable to Color Palette 2.0 specs.
There was a problem hiding this comment.
Changes have been done, Please review
badejayayesubabu
force-pushed
the
SURF-2113
branch
from
a9c70c8 to
42c2f97
Compare
badejayayesubabu
force-pushed
the
SURF-2113
branch
from
42c2f97 to
2cee3b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<hx-menu>: Implement and Document variables and attributesWhat are the relevant story cards/tickets? Any additional PRs or other references?
Jira: SURF-2113
Before you request a review for this PR:
yarn testto ensure all tests passed?