Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(releases): update component specs based on feedback #822

Merged
merged 1 commit into from
Jan 14, 2021
Merged

chore(releases): update component specs based on feedback #822

merged 1 commit into from
Jan 14, 2021

Conversation

100stacks
Copy link
Member

@100stacks 100stacks commented Jan 12, 2021 •
edited
Loading

Description

Minor tweaks based on user feedback from our Release Candidates.

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2167

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@100stacks 100stacks added the 🆕 New Component Specs Updated Component Specifications label Jan 12, 2021
@100stacks 100stacks added this to the HelixUI-v2.0.0 milestone Jan 12, 2021
@netlify
Copy link

netlify bot commented Jan 12, 2021 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit ff2ecbe

https://deploy-preview-822--helix-ui.netlify.app

@100stacks 100stacks mentioned this pull request Jan 13, 2021
Merged
9 tasks
@100stacks 100stacks force-pushed the surf-2167-releases-feedback branch from 3d7c8a7 to 62f2cfb Compare January 13, 2021 00:42
@100stacks 100stacks force-pushed the surf-2167-releases-feedback branch from 62f2cfb to ff2ecbe Compare January 13, 2021 01:30
lalithkarikelli
lalithkarikelli approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

@100stacks 100stacks removed the request for review from badejayayesubabu January 13, 2021 18:06
@100stacks 100stacks merged commit ecd4b6b into master Jan 14, 2021
@100stacks 100stacks deleted the surf-2167-releases-feedback branch March 25, 2021 18:57
@100stacks 100stacks restored the surf-2167-releases-feedback branch March 25, 2021 18:57
@100stacks 100stacks deleted the surf-2167-releases-feedback branch March 25, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

Assignees
No one assigned
Labels
🆕 New Component Specs Updated Component Specifications
Projects
None yet
Milestone
HelixUI-v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@100stacks @lalithkarikelli