Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(textinput): update component specs #811

Merged
merged 1 commit into from
Dec 23, 2020
Merged

refactor(textinput): update component specs #811

merged 1 commit into from
Dec 23, 2020

Conversation

lalithkarikelli
Copy link
Contributor

@lalithkarikelli lalithkarikelli commented Dec 21, 2020 •
edited
Loading

Description

<hx-textinput> implementing color palette 2.0 styles

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF2158

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Dec 21, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 808c371

https://deploy-preview-811--helix-ui.netlify.app

@lalithkarikelli lalithkarikelli marked this pull request as ready for review December 21, 2020 16:31
@100stacks 100stacks changed the title refactor(hx-textinput): Update to FabricUI Specs refactor(textinput): update component specs Dec 21, 2020
@100stacks 100stacks added this to the HelixUI-v2.0.0 milestone Dec 21, 2020
danielmdesigns
danielmdesigns suggested changes Dec 21, 2020
View reviewed changes
Copy link

@danielmdesigns danielmdesigns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text input looks great. My only feedback is that the red "Required" indicator line looks thicker than the default blue active indicator line. Can we adjust that so that they have the same thickness/border weight?

100stacks
100stacks requested changes Dec 21, 2020
View reviewed changes
@100stacks 100stacks added PR: Comments Provided PR: Comments Provided 🆕 New Component Specs Updated Component Specifications labels Dec 21, 2020
@lalithkarikelli
Copy link
Contributor Author

@danielmdesigns yes, it was 2px , now i have reduced it to 1px . Please review the change . Thanks !

danielmdesigns
danielmdesigns approved these changes Dec 22, 2020
View reviewed changes
Copy link

@danielmdesigns danielmdesigns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text input changes look good. Thanks!

100stacks
100stacks approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks merged commit 4d7096e into HelixDesignSystem:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmdesigns danielmdesigns danielmdesigns approved these changes

@100stacks 100stacks 100stacks approved these changes

Assignees
No one assigned
Labels
🆕 New Component Specs Updated Component Specifications
Projects
None yet
Milestone
HelixUI-v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lalithkarikelli @danielmdesigns @100stacks