Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(secnav): update secondary navigation component specs #810

Merged
merged 1 commit into from
Dec 23, 2020
Merged

refactor(secnav): update secondary navigation component specs #810

merged 1 commit into from
Dec 23, 2020

Conversation

lalithkarikelli
Copy link
Contributor

@lalithkarikelli lalithkarikelli commented Dec 18, 2020 •
edited
Loading

Description

<hx-secnav> : implementing color palette 2.0 styles

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF2143

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Dec 18, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 577c7ad

https://deploy-preview-810--helix-ui.netlify.app

@lalithkarikelli lalithkarikelli marked this pull request as ready for review December 18, 2020 15:52
@lalithkarikelli lalithkarikelli changed the title refactor(hx-secnav): Secondary Navigation component refactor(secnav): update second navigation component specs Dec 18, 2020
danielmdesigns
danielmdesigns suggested changes Dec 21, 2020
View reviewed changes
Copy link

@danielmdesigns danielmdesigns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the dropdown section headings, we want to remove all caps. They should be title case, no more all caps.

100stacks
100stacks requested changes Dec 21, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see changes below and squash commits.

docs/components/secnav/index.html
@@ -18,7 +18,7 @@
{% endblock %}

{% block content %}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, please review.

docs/components/secnav/index.html
@@ -28,14 +28,14 @@ <h3>
</h3>
<br />
</header>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, please review.

docs/components/secnav/index.html Outdated
@@ -53,17 +53,17 @@ <h3>
<hx-icon type="bell"></hx-icon>
<p>Notifications</p>
</a>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra space.

docs/components/secnav/index.html Outdated
<a href="#" class="selected">
<hx-icon type="ticketing"></hx-icon>
<p>Tickets</p>
</a>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra space.

docs/components/secnav/index.html Outdated
<a href="#">
<hx-icon type="support"></hx-icon>
<p>Support</p>
</a>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra space.

src/scss/components/secnav/index.scss Outdated
padding: 0.5rem 1.25rem;

&:hover {
background-color: $gray-800;
color: $gray-0 !important;
color: #970c8d !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to:

color: $purple-500 !important;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, please review.

src/scss/components/secnav/index.scss Outdated
border-color: $gray-800;
height: 1px;
border-color: $gray-300;
height: 0.063rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change:

height: 1px;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, please review.

src/scss/components/secnav/index.scss Outdated
@@ -56,36 +53,35 @@
@include hxSecNavControl(disabled);
}

&[aria-expanded="true"] {
color: #98008d;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to:

color: $purple-500;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, please review.

docs/components/secnav/test.html Outdated
<hx-disclosure aria-controls="demo-user-menu">
<span>Jane User</span>
<div class="hxTopNavMenu hxTopNavOptionMenu">
<hx-disclosure aria-controls="topnav-menu-options" aria-expanded="true">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the aria-expanded attribute, since this is the demo for Secondary Navigation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, please review.

@100stacks 100stacks added this to the HelixUI-v2.0.0 milestone Dec 21, 2020
@100stacks 100stacks added the 🆕 New Component Specs Updated Component Specifications label Dec 21, 2020
@lalithkarikelli
Copy link
Contributor Author

@danielmdesigns i have removed all caps for dropdown section headings . Please review the change. Thanks !

danielmdesigns
danielmdesigns approved these changes Dec 22, 2020
View reviewed changes
Copy link

@danielmdesigns danielmdesigns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for first phase release!

@100stacks 100stacks removed the PR: Comments Provided PR: Comments Provided label Dec 23, 2020
100stacks
100stacks approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks changed the title refactor(secnav): update second navigation component specs refactor(secnav): update secondary navigation component specs Dec 23, 2020
@100stacks 100stacks merged commit f5db7ef into HelixDesignSystem:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmdesigns danielmdesigns danielmdesigns approved these changes

@100stacks 100stacks 100stacks approved these changes

Assignees
No one assigned
Labels
🆕 New Component Specs Updated Component Specifications
Projects
None yet
Milestone
HelixUI-v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lalithkarikelli @danielmdesigns @100stacks