Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radio): new color palette specs #808

Merged
merged 1 commit into from
Dec 21, 2020
Merged

feat(radio): new color palette specs #808

merged 1 commit into from
Dec 21, 2020

Conversation

100stacks
Copy link
Member

@100stacks 100stacks commented Dec 17, 2020 •
edited
Loading

Description

  • Radio component - new color palette specs

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2148

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@100stacks 100stacks added this to the HelixUI-v2.0.0 milestone Dec 17, 2020
@netlify
Copy link

netlify bot commented Dec 17, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 2894c50

https://deploy-preview-808--helix-ui.netlify.app

@100stacks 100stacks force-pushed the surf-2148-radio-button-specs branch from 11d030c to 72f85ea Compare December 17, 2020 19:52
@100stacks 100stacks force-pushed the surf-2148-radio-button-specs branch from 72f85ea to f4d4ab3 Compare December 17, 2020 21:03
@100stacks 100stacks force-pushed the surf-2148-radio-button-specs branch from f4d4ab3 to 2894c50 Compare December 17, 2020 21:44
lalithkarikelli
lalithkarikelli approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

danielmdesigns
danielmdesigns approved these changes Dec 21, 2020
View reviewed changes
Copy link

@danielmdesigns danielmdesigns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for first phase!

@100stacks 100stacks added the CSS label Dec 21, 2020
@100stacks 100stacks merged commit 4e6c4e1 into master Dec 21, 2020
@100stacks 100stacks added 🆕 New Component Specs Updated Component Specifications and removed CSS labels Dec 21, 2020
@100stacks 100stacks deleted the surf-2148-radio-button-specs branch March 4, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmdesigns danielmdesigns danielmdesigns approved these changes

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

Assignees
No one assigned
Labels
🆕 New Component Specs Updated Component Specifications
Projects
None yet
Milestone
HelixUI-v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@100stacks @danielmdesigns @lalithkarikelli